samples: mesh: nrf52: removed unwanted code#12017
Closed
vikrant8052 wants to merge 3 commits intozephyrproject-rtos:masterfrom
vikrant8052:fix_bugs24
Closed
samples: mesh: nrf52: removed unwanted code#12017vikrant8052 wants to merge 3 commits intozephyrproject-rtos:masterfrom vikrant8052:fix_bugs24
vikrant8052 wants to merge 3 commits intozephyrproject-rtos:masterfrom
vikrant8052:fix_bugs24
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12017 +/- ##
=======================================
Coverage 48.05% 48.05%
=======================================
Files 281 281
Lines 43412 43412
Branches 10404 10404
=======================================
Hits 20863 20863
Misses 18400 18400
Partials 4149 4149Continue to review full report at Codecov.
|
Contributor
Author
|
Please wait. |
jhedberg
requested changes
Dec 11, 2018
Member
There was a problem hiding this comment.
There are many things wrong with this:
- It should be a helper function
- It should have a descriptive name matching what it does
- Even if it was a macro it should be all upper-case
Contributor
Author
There was a problem hiding this comment.
Removed that macro. So issue has solved !!
|
All checks are passing now. Review history of this comment for details about previous failed status. |
Contributor
Author
Removed unwanted code which is not allowing GET response to get send by Server to client. After removing this, there is improvement in GATT Bearer performance while testing with Android nRFMesh App. Signed-off-by: Vikrant More <vikrant8051@gmail.com>
Reassignment of last target values as per present values after NODE reset as well as after every transition get completed. Signed-off-by: Vikrant More <vikrant8051@gmail.com>
Removed bug which get introduced by PR:9521. Because of it not able to save App's variable on SoC flash. Signed-off-by: Vikrant More <vikrant8051@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unwanted code which is not allowing GET response
to get send by Server to client. After removing this, there
is improvement in GATT Bearer performance while testing
with Android nRFMesh App.
Signed-off-by: Vikrant More vikrant8051@gmail.com